From 55bbf9098a888e815841964586ed6e5c80783094 Mon Sep 17 00:00:00 2001
From: Diego Barrios Romero <eldruin@gmail.com>
Date: Fri, 16 Nov 2018 19:32:33 +0100
Subject: [PATCH] Put construction tests together

---
 tests/construction.rs | 17 +++++++++++++++++
 tests/ds3231.rs       | 10 ----------
 tests/ds3232.rs       | 10 ----------
 tests/ds3234.rs       |  7 -------
 4 files changed, 17 insertions(+), 27 deletions(-)
 create mode 100644 tests/construction.rs
 delete mode 100644 tests/ds3231.rs
 delete mode 100644 tests/ds3232.rs

diff --git a/tests/construction.rs b/tests/construction.rs
new file mode 100644
index 0000000..41b550a
--- /dev/null
+++ b/tests/construction.rs
@@ -0,0 +1,17 @@
+mod common;
+use common::{ new_ds3231, destroy_ds3231, new_ds3232, destroy_ds3232,
+              new_ds3234, destroy_ds3234 };
+
+macro_rules! construction_test {
+    ($name:ident, $create:ident, $destroy:ident) => {
+        #[test]
+        fn $name() {
+            let dev = $create(&[]);
+            $destroy(dev);
+        }
+    };
+}
+
+construction_test!(can_create_ds3231, new_ds3231, destroy_ds3231);
+construction_test!(can_create_ds3232, new_ds3232, destroy_ds3232);
+construction_test!(can_create_ds3234, new_ds3234, destroy_ds3234);
diff --git a/tests/ds3231.rs b/tests/ds3231.rs
deleted file mode 100644
index d4ef9cd..0000000
--- a/tests/ds3231.rs
+++ /dev/null
@@ -1,10 +0,0 @@
-extern crate embedded_hal_mock as hal;
-extern crate ds323x;
-use ds323x::Ds323x;
-
-#[test]
-fn can_create_and_destroy() {
-    let dev = Ds323x::new_ds3231(hal::i2c::Mock::new(&[]));
-    let mut i2c = dev.destroy_ds3231();
-    i2c.done();
-}
diff --git a/tests/ds3232.rs b/tests/ds3232.rs
deleted file mode 100644
index 0249814..0000000
--- a/tests/ds3232.rs
+++ /dev/null
@@ -1,10 +0,0 @@
-extern crate embedded_hal_mock as hal;
-extern crate ds323x;
-use ds323x::Ds323x;
-
-#[test]
-fn can_create_and_destroy() {
-    let dev = Ds323x::new_ds3232(hal::i2c::Mock::new(&[]));
-    let mut i2c = dev.destroy_ds3232();
-    i2c.done();
-}
diff --git a/tests/ds3234.rs b/tests/ds3234.rs
index ec57a2c..5f88218 100644
--- a/tests/ds3234.rs
+++ b/tests/ds3234.rs
@@ -1,17 +1,10 @@
 extern crate embedded_hal_mock as hal;
 use hal::spi::Transaction as SpiTrans;
-extern crate ds323x;
 
 #[allow(unused)]
 mod common;
 use common::{ new_ds3234, destroy_ds3234, Register, BitFlags };
 
-#[test]
-fn can_create_and_destroy_ds3234() {
-    let dev = new_ds3234(&[]);
-    destroy_ds3234(dev);
-}
-
 call_test!(can_en_temp_conv_bat, enable_temperature_conversions_on_battery, new_ds3234, destroy_ds3234,
     [ SpiTrans::write(vec![Register::TEMP_CONV + 0x80, 0]) ]);