47 lines
1.7 KiB
Python
47 lines
1.7 KiB
Python
|
# Copyright (c) 2014 Google, Inc.
|
||
|
|
# Copyright (c) 2015-2016 Claudiu Popa <pcmanticore@gmail.com>
|
||
|
|
|
||
|
|
# Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
|
||
|
|
# For details: https://github.com/PyCQA/pylint/blob/master/COPYING
|
||
|
|
|
||
|
|
"""Unittest for the logging checker."""
|
||
|
|
import astroid
|
||
|
|
|
||
|
|
from pylint.checkers import logging
|
||
|
|
from pylint.testutils import CheckerTestCase, Message, set_config
|
||
|
|
|
||
|
|
|
||
|
|
class TestLoggingModuleDetection(CheckerTestCase):
|
||
|
|
CHECKER_CLASS = logging.LoggingChecker
|
||
|
|
|
||
|
|
def test_detects_standard_logging_module(self):
|
||
|
|
stmts = astroid.extract_node("""
|
||
|
|
import logging #@
|
||
|
|
logging.warn('%s' % '%s') #@
|
||
|
|
""")
|
||
|
|
self.checker.visit_module(None)
|
||
|
|
self.checker.visit_import(stmts[0])
|
||
|
|
with self.assertAddsMessages(Message('logging-not-lazy', node=stmts[1])):
|
||
|
|
self.checker.visit_call(stmts[1])
|
||
|
|
|
||
|
|
def test_detects_renamed_standard_logging_module(self):
|
||
|
|
stmts = astroid.extract_node("""
|
||
|
|
import logging as blogging #@
|
||
|
|
blogging.warn('%s' % '%s') #@
|
||
|
|
""")
|
||
|
|
self.checker.visit_module(None)
|
||
|
|
self.checker.visit_import(stmts[0])
|
||
|
|
with self.assertAddsMessages(Message('logging-not-lazy', node=stmts[1])):
|
||
|
|
self.checker.visit_call(stmts[1])
|
||
|
|
|
||
|
|
@set_config(logging_modules=['logging', 'my.logging'])
|
||
|
|
def test_nonstandard_logging_module(self):
|
||
|
|
stmts = astroid.extract_node("""
|
||
|
|
from my import logging as blogging #@
|
||
|
|
blogging.warn('%s' % '%s') #@
|
||
|
|
""")
|
||
|
|
self.checker.visit_module(None)
|
||
|
|
self.checker.visit_import(stmts[0])
|
||
|
|
with self.assertAddsMessages(Message('logging-not-lazy', node=stmts[1])):
|
||
|
|
self.checker.visit_call(stmts[1])
|